-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support cuckoo filter and most commands #2545
Closed
Closed
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
4ce2a76
Version Save
jonathanc-n 01c6a8c
cf commit
jonathanc-n 6e8cb13
Cuckoo lint
jonathanc-n 86134ab
small lint + comment clean
jonathanc-n 3986cb7
Merge branch 'unstable' into cuckoo-filter
jonathanc-n 408d07f
added missing license
jonathanc-n c22eff9
Merge branch 'cuckoo-filter' of https://github.com/jonathanc-n/kvrock…
jonathanc-n b8f1567
remove dependencies
jonathanc-n 442b656
Merge branch 'unstable' into cuckoo-filter
jonathanc-n fb70d53
Added helper functions
jonathanc-n 7c68229
Merge branch 'unstable' into cuckoo-filter
jonathanc-n ac0f40d
Merge branch 'unstable' into cuckoo-filter
jonathanc-n c827361
Merge branch 'unstable' into cuckoo-filter
jonathanc-n 84b7608
Merge branch 'unstable' into cuckoo-filter
jonathanc-n File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I doubt the efficiency of this approach: everytime we read/update the filters, we need to retrieve/put all of these filters.
Please refer to the design of bloom filters to see if you can put filters to multiple key values.