Addressed Jun's comments

apache · Nov 15, 2024 · 5f343a5 · 5f343a5
1 parent f7d1c89
commit 5f343a5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/core/src/main/java/kafka/server/share/DelayedShareFetch.java b/core/src/main/java/kafka/server/share/DelayedShareFetch.java
@@ -90,7 +90,7 @@ public void onExpiration() {
      */
     @Override
     public void onComplete() {
-        // We are utilizing lock so that onComplete doesn't do a dirty read for global variables -
+        // We are utilizing lock so that onComplete doesn't do a dirty read for instance variables -
         // partitionsAcquired and partitionsAlreadyFetched, since these variables can get updated in a different tryComplete thread.
         lock.lock();
         log.trace("Completing the delayed share fetch request for group {}, member {}, "

diff --git a/core/src/main/java/kafka/server/share/SharePartition.java b/core/src/main/java/kafka/server/share/SharePartition.java
@@ -2426,6 +2426,7 @@ public String toString() {
      * FetchOffsetMetadata class is used to cache offset and its log metadata.
      */
     static final class OffsetMetadata {
+        // This offset could be different from offsetMetadata.messageOffset if it's in the middle of a batch.
         private long offset;
         private LogOffsetMetadata offsetMetadata;