Improvements to code involving synchronized maps #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ajor version number
ghost
changed the title
This also fixes potential non-determinism in resizeAll() because all access to the caches map must be synchronized, but the caches.size() call wasn't synchronized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These are some improvements to
org.apache.jackrabbit.jcr2spi.ItemImpland other classes which use synchronized maps.The
listenersmember ofItemImplshould be made private because subclasses should not be allowed to mutate this map or iterate over it. Iterating over the map requires proper synchronization or else non-deterministic behavior can occur.Also, the changes to throw
NullPointerExceptionif anItemLifeCycleListenerinstance isnullis not really a change, because it was implicitly assumed that the listeners would not benull(notifyCreated() invokes itemCreated() on each initial listener without checking fornull).I would classify these changes as efficiency and code improvements, with three exceptions that fix concurrency issues: