OAK-11078: Remove usage of Guava checkArgument #1687
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbaedke
requested changes
Sep 6, 2024
| @@ -244,8 +244,8 @@ public static String checkValidName(String asyncName){ | |||
| if (IndexConstants.ASYNC_REINDEX_VALUE.equals(asyncName)){ | |||
| return asyncName; | |||
| } | |||
| checkArgument(asyncName.endsWith("async"), "async name [%s] does not confirm to " + | |||
| "naming pattern of ending with 'async'", asyncName); | |||
| Validate.isTrue(asyncName.endsWith("async"), "async name [%s] does not confirm to naming pattern of ending with 'async'", | |||
| @@ -700,7 +700,7 @@ private static final class TreeNode { | |||
| } | |||
|
|
|||
| TreeNode(MapFactory mapFactory, TreeNode parent, String name) { | |||
| checkArgument(!name.contains("/"), | |||
| Validate.isTrue(!name.contains("/"), | |||
There was a problem hiding this comment.
Does "{}" even work in a format string?
There was a problem hiding this comment.
No, according to the documentation (even in checkArgument)
so yes, this needs to be fixed.
rishabhdaim
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before proceeding with this, I'd love to get some feedback.
JDK lacks this feature. We can either use something identical from commons-lang (which we use anyway, and which I did here), or roll our own.
Opinions?
(note that I also took the freedom to fix "{}" in format strings, and to avoid string concatenation)