Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[486] Change artifact name to incubator-xtable and Add deploy plugin to mvn #498

Merged
merged 1 commit into from
Aug 2, 2024

Conversation

vinishjail97
Copy link
Contributor

@vinishjail97 vinishjail97 commented Jul 30, 2024

Important Read

  • Please ensure the GitHub issue is mentioned at the beginning of the PR

What is the purpose of the pull request

#486
According to apache guidelines, we need to prefix the "incubator" prefix for all artifacts deployed to maven. This is how the bundled jar will look like in maven central repository when uploaded.

<dependency>
<groupId>org.apache.xtable</groupId>
<artifactId>incubator-xtable-utilities</artifactId>
<version>0.1.0-rc1</version>
<classifier>bundled</classifier>
</dependency>

Brief change log

(for example:)

  • Added the mvn release and deploy plugins
  • Made few other changes for generating java docs when lombok builders are present

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

Validated the below command by uploading the rc-1 artifacts to staging repository.
mvn deploy -Prelease -DskipTests -DdeployArtifacts=true

@vinishjail97 vinishjail97 changed the title Change artifact name to incubator-xtable and Add deploy plugin to mvn [486] Change artifact name to incubator-xtable and Add deploy plugin to mvn Jul 30, 2024
pom.xml Outdated Show resolved Hide resolved
@vinishjail97
Copy link
Contributor Author

Squashed everything into a single commit.

@vinishjail97 vinishjail97 merged commit 5baf117 into main Aug 2, 2024
3 checks passed
@vinishjail97 vinishjail97 deleted the ArtifactNameChange branch August 2, 2024 06:56
@jcamachor
Copy link
Contributor

Sorry for the late response, I was OOF. Thanks, @vinishjail97, for putting the PR together. Could you share the ASF guidelines you are referring to? AFAIK the common practice is adding the -incubating suffix to the release version until the project graduates to TLP, rather than changing the artifact names (which makes sense so any consumer can update the version without changing the artifact ID all over). From a quick look at other incubating projects, that seem to be the practice that they are following. Also cc'ing @zabetak and @jbonofre in case they have any insights about this.

@vinishjail97
Copy link
Contributor Author

vinishjail97 commented Aug 7, 2024

The Incubator policies applies two additional constraints to podlings for their releases. They are repeated here for clarity only. - Release artifacts must include incubating in the final file name - Release artifacts must include one of two disclaimers

I was refereeing to these guidelines, reading it again looks like you may be right. I misunderstood this sentence.
Release artifacts must include incubating in the final file name

@jcamachor
Copy link
Contributor

Yes, looking at the artifacts of other incubating projects, version looks like <version>-incubating.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants