Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]Fix jar library with task dependencies can be successfully deleted #4124

Merged
merged 1 commit into from
Nov 1, 2024

Conversation

Happy-shi
Copy link
Contributor

@Happy-shi Happy-shi commented Oct 29, 2024

What changes were proposed in this pull request

Issue Number: close #4123

Brief change log

the jar library with task dependencies should not be successfully deleted

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (no)

Copy link

sonarcloud bot commented Oct 29, 2024

Copy link
Member

@wolfboys wolfboys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Happy-shi
Copy link
Contributor Author

@wolfboys hello, what should I do with the above failing checks

@wolfboys wolfboys merged commit 3a44fe0 into apache:dev Nov 1, 2024
45 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] jar library with task dependencies can be successfully deleted
2 participants