-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat][Flink-K8s-V2] Refactor the lifecycle control of Flink K8s application-mode jobs #3037
Conversation
… savepoint operations . apache#2882
Hi @caicancai, This PR is a fix for the code in PR #2994, and also a complete implementation of issue #2882. It can serve as a reference for your upcoming implementations of #2883 and #2884. |
@wolfboys Please take a look. |
Thank you |
This is a good idea |
|
||
// ======= deprecated ======= | ||
|
||
@deprecated |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
StreamPark consists of two parts: a development framework and a stream processing platform. The development framework part provides some APIs to users. The parameter InternalOption was originally designed for internal use within the platform, It is a non-public API. Therefore, these parameters can be deleted directly without causing any other impact on users
Do k8sv2 and the current k8s native approach support parallel usage, or does k8sv2 replace the implementation of k8s native, only keep k8sv2? |
I think v2 is still in the development stage and is not stable yet. I will delete the v1 code after the development is tested and there are no problems. |
okay 👌 This is a relatively secure/reliable approach |
KubernetesSubmitParam kubernetesSubmitParam = | ||
new KubernetesSubmitParam( | ||
KubernetesSubmitParam.apply( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
There may still be some small issues, but let's merge this PR first and continue improving it later. This also makes it easier for other developers to collaborate and improve together.
What changes were proposed in this pull request
Issue Number: close #2882
Brief change log
Does this pull request potentially affect one of the following parts