Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hotfix][translation] Translate the ignored comments. #3011

Merged
merged 5 commits into from
Sep 1, 2023
Merged

[Hotfix][translation] Translate the ignored comments. #3011

merged 5 commits into from
Sep 1, 2023

Conversation

caicancai
Copy link
Member

@caicancai caicancai commented Sep 1, 2023

What changes were proposed in this pull request

Translate some comments into English

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

@github-actions github-actions bot removed the BACKEND label Sep 1, 2023
@RocMarshal RocMarshal changed the title Translation notes [Hotfix][translation] Translate the ignored comments. Sep 1, 2023
Copy link
Contributor

@RocMarshal RocMarshal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review @caicancai
LGTM +1.

@RocMarshal RocMarshal merged commit c1a2847 into apache:dev Sep 1, 2023
6 checks passed
saLeox pushed a commit to saLeox/incubator-streampark that referenced this pull request Sep 4, 2023
@caicancai caicancai deleted the Translation_notes branch September 5, 2023 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants