add ingress annotation: kubernetes.io/ingress.class #2999
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @Al-assad |
|
Hi @chenshaojin, there are some code style issues in this pull request |
ok, I will format the code style. |
wolfboys
reviewed
Aug 31, 2023
| "nginx.ingress.kubernetes.io/rewrite-target" -> "/$2", | ||
| "nginx.ingress.kubernetes.io/proxy-body-size" -> "1024m", | ||
| "nginx.ingress.kubernetes.io/configuration-snippet" -> ("rewrite ^(/" + clusterId + ")$ $1/ permanent;") | ||
| ) | ||
| val ingressClass = InternalConfigHolder.get[String](K8sFlinkConfig.ingressClass) |
There was a problem hiding this comment.
It can be improved to make the logic clearer：
val ingressClass = InternalConfigHolder.get[String](K8sFlinkConfig.ingressClass)
if (ingressClass.nonEmpty) {
annotations + ("kubernetes.io/ingress.class" -> ingressClass)
}
annotations
|
@chenshaojin there are some code style issues in PR, you can run command to fix it: |
I see. thx |
|
cc @wolfboys |
saLeox
pushed a commit
to saLeox/incubator-streampark
that referenced
this pull request
Sep 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Issue Number: close #2998