-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ISSUE-2988][Bug] Update helm template, fix streampark on k8s failed #2990
Conversation
cc @Al-assad |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, these codes look great 😃
deploy/helm/README.md
Outdated
|
||
### 3. open WebUI | ||
|
||
http://streampark.apache.org/streampark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
WebUI error, prompt the user to open the browser based on the actual URL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you are right
securityContext: | ||
privileged: false | ||
command: ["bash","-c","bash bin/startup.sh"] | ||
command: ["bash","-c","bash ./bin/streampark.sh start_docker"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good job
cc @Al-assad PTAL , thx |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you for merging my code. |
What changes were proposed in this pull request
Issue Number: close #2988
Brief change log
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
1、The ingress does not have a namespace.
2、The ingress may need to specify the ingress controller.
3、A 404 error occurs when accessing swagger.
4、The startup command cannot use startup.sh because it is nohup. You need to use ./streampark.sh start_docker
5、The resources attribute must be added.
6、add env. Solve the docker log garbled code problem.
7、dind uses tcp:xxxx:2375, which is a bit more convenient.
8、use ingress. The front-end code needs to be recompiled. Modify the .env.production file to change VITE_PUBLIC_PATH and VITE_GLOB_API_URL_PREFIX to the ingress path, likely /streampark.