Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE-2988][Bug] Update helm template, fix streampark on k8s failed #2990

Merged
merged 5 commits into from
Aug 29, 2023
Merged

[ISSUE-2988][Bug] Update helm template, fix streampark on k8s failed #2990

merged 5 commits into from
Aug 29, 2023

Conversation

chenshaojin
Copy link
Contributor

What changes were proposed in this pull request

Issue Number: close #2988

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

1、The ingress does not have a namespace.
2、The ingress may need to specify the ingress controller.
3、A 404 error occurs when accessing swagger.
4、The startup command cannot use startup.sh because it is nohup. You need to use ./streampark.sh start_docker
5、The resources attribute must be added.
6、add env. Solve the docker log garbled code problem.
7、dind uses tcp:xxxx:2375, which is a bit more convenient.
8、use ingress. The front-end code needs to be recompiled. Modify the .env.production file to change VITE_PUBLIC_PATH and VITE_GLOB_API_URL_PREFIX to the ingress path, likely /streampark.

@chenshaojin
Copy link
Contributor Author

cc @Al-assad

@Al-assad
Copy link
Member

cc @Al-assad
It seems that there are dead links in the README file.
image

Al-assad
Al-assad previously approved these changes Aug 28, 2023
Copy link
Member

@Al-assad Al-assad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, these codes look great 😃

@RocMarshal RocMarshal changed the title update helm template & fix bug [ISSUE-2988][Bug] Update helm template, fix streampark on k8s failed Aug 28, 2023

### 3. open WebUI

http://streampark.apache.org/streampark
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WebUI error, prompt the user to open the browser based on the actual URL.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are right

securityContext:
privileged: false
command: ["bash","-c","bash bin/startup.sh"]
command: ["bash","-c","bash ./bin/streampark.sh start_docker"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

@wolfboys
Copy link
Member

cc @Al-assad PTAL , thx

Copy link
Member

@Al-assad Al-assad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Al-assad Al-assad merged commit 81c73c3 into apache:dev Aug 29, 2023
6 checks passed
@chenshaojin
Copy link
Contributor Author

Thank you for merging my code. v

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] update helm template, fix streampark on k8s failed
3 participants