[Improvement] avoid errors in batch insert caused by different tables or columns #2919
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor sinkRequest.sqlStatement to avoid errors in batch insert: 1) Group and combine statements by the part before ‘values’ in insert statements. 2) Handle different tables or columns that may cause errors in batch insert.
wolfboys
reviewed
Aug 5, 2023
...nnector-base/src/main/scala/org/apache/streampark/flink/connector/failover/SinkRequest.scala
Outdated
Show resolved
Hide resolved
add logger and refine warning log
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request
Add support for different tables or columns in batch insert.
Brief change log
Refactor val SinkRequest.sqlStatement: group and combine statements by the part before ‘values’ in insert statements.
Verifying this change
This change is a trivial rework / code cleanup without any test coverage.
Does this pull request potentially affect one of the following parts