IngressController code optimization #2913
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-assad
requested changes
Aug 5, 2023
| /** get new KubernetesClient */ | ||
| @throws(classOf[KubernetesClientException]) | ||
| def newK8sClient(): KubernetesClient = { | ||
| new DefaultKubernetesClient() | ||
| def getK8sClient(): KubernetesClient = { |
There was a problem hiding this comment.
There are better ways to implement the singleton pattern in scala:
private lazy val kubernetesClient: KubernetesClient = new DefaultKubernetesClient()
def getK8sClient(): KubernetesClient = kubernetesClientThere was a problem hiding this comment.
Ok, thanks for reviewing the code
wolfboys
reviewed
Aug 6, 2023
| @@ -107,7 +116,7 @@ object KubernetesRetriever extends Logger { | |||
| * deployment namespace | |||
| */ | |||
| def isDeploymentExists(name: String, namespace: String): Boolean = { | |||
| using(KubernetesRetriever.newK8sClient()) { | |||
| using(KubernetesRetriever.getK8sClient()) { | |||
There was a problem hiding this comment.
The KubernetesRetriever.getK8sClient() method will return a singleton KubernetesClient. However, the using method closes the KubernetesClient after used, which can lead to bugs.
There was a problem hiding this comment.
Ok, thanks for reviewing the code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IngressController code optimization