[VL] Hide symbols defined by gflags for libvelox.so #7820
+6
−8
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This is a follow-up pr for this comment.
If not hidden, the below error can be reported when running gluten CPP test.
velox_memory_num_shared_leaf_pools
is declared in Velox undergoogle
namespace. SeeDEFINE_int32
used by this velox code. Even thoughlocal: *;
is defined for version script, we have to explicitly make all symbols under*google::*
namespace hidden. The possible reason is that the specified global*facebook::velox::*
symbols cover those*google::*
symbols.How was this patch tested?
CI.