Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Hide symbols defined by gflags for libvelox.so #7820

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Nov 5, 2024

What changes were proposed in this pull request?

This is a follow-up pr for this comment.

If not hidden, the below error can be reported when running gluten CPP test.

something wrong with flag 'velox_memory_num_shared_leaf_pools' in file '/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/flag_definitions/flags.cpp'.  One possibility: file '/__w/incubator-gluten/incubator-gluten/ep/build-velox/build/velox_ep/velox/flag_definitions/flags.cpp' is being linked both statically and dynamically into this executable.
CMake Error at /usr/local/lib64/python3.9/site-packages/cmake/data/share/cmake-3.28/Modules/GoogleTestAddTests.cmake:112 (message):
Error running test executable.

  Path: '/__w/incubator-gluten/incubator-gluten/cpp/build/velox/tests/velox_shuffle_writer_test'

velox_memory_num_shared_leaf_pools is declared in Velox under google namespace. See DEFINE_int32 used by this velox code. Even though local: *; is defined for version script, we have to explicitly make all symbols under *google::* namespace hidden. The possible reason is that the specified global *facebook::velox::* symbols cover those *google::* symbols.

How was this patch tested?

CI.

@github-actions github-actions bot added the VELOX label Nov 5, 2024
Copy link

github-actions bot commented Nov 5, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Nov 6, 2024

@zml1206, could you take a look? This is a follow-up for a comment in your merged pr.

Copy link
Contributor

@zml1206 zml1206 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you.

@PHILO-HE
Copy link
Contributor Author

PHILO-HE commented Nov 6, 2024

Just found some other issue. Let's hold on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants