[GLUTEN-7778][CH] Make aggregation output schema same as CH native #7811
+53
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
1be8b9d
to
3266361
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
3266361
to
b30edcb
Compare
|
Run Gluten Clickhouse CI |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
b30edcb
to
847f29f
Compare
|
Run Gluten Clickhouse CI |
1 similar comment
|
Run Gluten Clickhouse CI |
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
52c58ef
to
75a588e
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
f63624c
to
48738a7
Compare
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
48738a7
to
f1cd9b4
Compare
|
Run Gluten Clickhouse CI on x86 |
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
f1cd9b4
to
adb58e1
Compare
|
Run Gluten Clickhouse CI on x86 |
1 similar comment
|
Run Gluten Clickhouse CI on x86 |
lgbo-ustc
force-pushed
the
unity_agg_output
branch
from
24fe672
to
b521269
Compare
|
Run Gluten Clickhouse CI on x86 |
zzcclp
approved these changes
Nov 6, 2024
| @@ -245,6 +284,7 @@ case class CHHashAggregateExecTransformer( | |||
| "PartialMerge's child not being HashAggregateExecBaseTransformer" + | |||
| " is unsupported yet") | |||
| } | |||
| val hashAggregateChild = child.asInstanceOf[BaseAggregateExec] | |||
There was a problem hiding this comment.
remove this line, it's unused ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
(Please fill in changes proposed in this fix)
Fixes: #7778
How was this patch tested?
(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)
unit tests
(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)