Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7143][VL] RAS: Enable the RAS UT jobs in GHA CI #7770

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Nov 1, 2024

Part of #7143

After a series of efforts, the failed UTs when RAS=ON should be all fixed. Enable the GHA jobs introduced in #7702 so they can guard against RAS from regressions.

After the change, every PR should pass the following UT jobs otherwise CI will fail:

  • run-spark-test-spark35-ras
  • run-spark-test-spark35-slow-ras

We would keep observing on the jobs. When the time is ripe, we can set RAS planner as the default planner then finish #7143. And before that, a comprehensive community discussion will be needed.

@github-actions github-actions bot added the INFRA label Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

#7143

Copy link
Contributor

@marin-ma marin-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhztheplayer zhztheplayer merged commit 71b7645 into apache:main Nov 5, 2024
45 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_11_05_2024_time.csv log/native_master_11_03_2024_95170df224_time.csv difference percentage
q1 52.41 53.48 1.063 102.03%
q2 31.37 29.65 -1.726 94.50%
q3 54.42 53.06 -1.355 97.51%
q4 43.58 43.97 0.392 100.90%
q5 104.27 104.85 0.576 100.55%
q6 13.06 11.85 -1.214 90.71%
q7 111.13 113.45 2.323 102.09%
q8 115.24 117.30 2.066 101.79%
q9 170.17 172.75 2.579 101.52%
q10 66.86 67.78 0.920 101.38%
q11 26.91 27.65 0.743 102.76%
q12 33.76 30.52 -3.239 90.41%
q13 52.53 51.73 -0.805 98.47%
q14 25.31 24.54 -0.772 96.95%
q15 51.09 50.61 -0.474 99.07%
q16 17.24 17.77 0.535 103.10%
q17 125.66 125.13 -0.529 99.58%
q18 198.47 200.43 1.958 100.99%
q19 30.01 27.84 -2.170 92.77%
q20 44.58 42.52 -2.068 95.36%
q21 332.16 330.10 -2.054 99.38%
q22 15.95 16.12 0.172 101.08%
total 1716.19 1713.11 -3.078 99.82%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants