Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-7143][VL] RAS: Catch exceptions thrown from rewrite rules #7767

Merged
merged 2 commits into from
Nov 1, 2024

Conversation

zhztheplayer
Copy link
Member

Part of #7143

Catch the exceptions to align with legacy planner.

Moving forward, should fix #7766.

This fixes UT GlutenReplaceHashWithSortAggSuite | Gluten - replace partial and final hash aggregate together with sort aggregate

@zhztheplayer zhztheplayer changed the title [VL] RAS: Catch exception thrown from rewrite rules [GLUTEN-7143][VL] RAS: Catch exception thrown from rewrite rules Nov 1, 2024
@github-actions github-actions bot added the CORE works for Gluten Core label Nov 1, 2024
@zhztheplayer zhztheplayer changed the title [GLUTEN-7143][VL] RAS: Catch exception thrown from rewrite rules [GLUTEN-7143][VL] RAS: Catch exceptions thrown from rewrite rules Nov 1, 2024
Copy link

github-actions bot commented Nov 1, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

github-actions bot commented Nov 1, 2024

#7143

Copy link

github-actions bot commented Nov 1, 2024

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Nov 1, 2024

Run Gluten Clickhouse CI

@zhztheplayer
Copy link
Member Author

@zzcclp Is the following a known issue from CH CI? I bumped into this twice in different PRs and it doesn't seem to relate to my changes.

- test table bucketed by all typed columns *** FAILED ***
[2024-11-01T05:27:11.912Z]   Exception thrown while executing query:
[2024-11-01T05:27:11.912Z]   == Parsed Logical Plan ==
[2024-11-01T05:27:11.912Z]   'Project ['string_field, 'int_field, 'long_field, 'float_field, 'double_field, 'short_field, 'byte_field, 'boolean_field, 'decimal_field, 'date_field, 'timestamp_field]
[2024-11-01T05:27:11.912Z]   +- 'UnresolvedRelation [hive_orc_test], [], false
[2024-11-01T05:27:11.912Z]   
[2024-11-01T05:27:11.912Z]   == Analyzed Logical Plan ==
[2024-11-01T05:27:11.912Z]   string_field: string, int_field: int, long_field: bigint, float_field: float, double_field: double, short_field: smallint, byte_field: tinyint, boolean_field: boolean, decimal_field: decimal(38,18), date_field: date, timestamp_field: timestamp
[2024-11-01T05:27:11.912Z]   Project [string_field#422617, int_field#422618, long_field#422619L, float_field#422620, double_field#422621, short_field#422622, byte_field#422623, boolean_field#422624, decimal_field#422625, date_field#422626, timestamp_field#422627]
[2024-11-01T05:27:11.912Z]   +- SubqueryAlias spark_catalog.default.hive_orc_test
[2024-11-01T05:27:11.912Z]      +- Relation default.hive_orc_test[string_field#422617,int_field#422618,long_field#422619L,float_field#422620,double_field#422621,short_field#422622,byte_field#422623,boolean_field#422624,decimal_field#422625,date_field#422626,timestamp_field#422627] orc
[2024-11-01T05:27:11.912Z]   
...

@zhztheplayer zhztheplayer merged commit 527ab16 into apache:main Nov 1, 2024
45 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE works for Gluten Core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Exceptions used as control flow in RewriteSparkPlanRulesManager and rewrite rules
2 participants