Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[GLUTEN-7243][VL] Suspend the Velox task while reading an input Java iterator to make the task spillable #7748

Merged
merged 7 commits into from
Nov 5, 2024
Merged

[GLUTEN-7243][VL] Suspend the Velox task while reading an input Java iterator to make the task spillable #7748

merged 7 commits into from
Nov 5, 2024

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Oct 31, 2024 •
edited
Loading

This could be a better approach to replace #7244.

Could remove this commit from Gluten's Velox fork when this change is landed.

@github-actions github-actions bot added CORE works for Gluten Core VELOX labels Oct 31, 2024
@github-actions GitHub Actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@github-actions GitHub Actions

This comment was marked as resolved.

Sign in to view
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title PoC: [GLUTEN-7243][VL] Suspend the Velox task while reading the Java iterator to make the task spill-able PoC: [GLUTEN-7243][VL] Suspend the Velox task while reading an input Java iterator to make the task spill-able Oct 31, 2024
@github-actions GitHub Actions
Copy link

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title PoC: [GLUTEN-7243][VL] Suspend the Velox task while reading an input Java iterator to make the task spill-able PoC: [GLUTEN-7243][VL] Suspend the Velox task while reading an input Java iterator to make the task spillable Nov 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Run Gluten Clickhouse CI

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 1, 2024

Run Gluten Clickhouse CI

@zhztheplayer zhztheplayer changed the title PoC: [GLUTEN-7243][VL] Suspend the Velox task while reading an input Java iterator to make the task spillable [GLUTEN-7243][VL] Suspend the Velox task while reading an input Java iterator to make the task spillable Nov 5, 2024
@zhztheplayer zhztheplayer marked this pull request as ready for review November 5, 2024 07:24
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 5, 2024

#7243

marin-ma
marin-ma approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@marin-ma marin-ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhztheplayer zhztheplayer merged commit c928c89 into apache:main Nov 5, 2024
51 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marin-ma marin-ma marin-ma approved these changes

Assignees
No one assigned
Labels
CORE works for Gluten Core VELOX
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zhztheplayer @marin-ma