[VL] Fix field name parsing in Subfield #7330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
rui-mo
force-pushed
the
wip_subfield
branch
2 times, most recently
from
fab214c
to
cd561aa
Compare
rui-mo
force-pushed
the
wip_subfield
branch
from
cd561aa
to
02afcf1
Compare
PHILO-HE
approved these changes
Sep 25, 2024
|
CC @zhli1142015 |
|
@zml1206 Would you like to take a look? Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Parse the field names into Subfield directly without using the Tokenizer in Velox, which matches with Presto's semantics.
Fixes: #7282
Fixes: #6843
How was this patch tested?
With unit test.