Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE][1.2] Bump branch-1.2 version to 1.2.1-SNAPSHOT #7290

Merged
merged 2 commits into from
Sep 24, 2024

Conversation

weiting-chen
Copy link
Contributor

What changes were proposed in this pull request?

Bump branch-1.2 version to 1.2.1-SNAPSHOT

How was this patch tested?

local server

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

@@ -7,7 +7,7 @@
<parent>
<groupId>org.apache.gluten</groupId>
<artifactId>gluten-it</artifactId>
<version>1.2.0</version>
<version>1.2.1-SNAPSHOT</version>
</parent>

<artifactId>gluten-it-common</artifactId>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weiting-chen, this should also be bumped.

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@weiting-chen weiting-chen merged commit a6469bf into apache:branch-1.2 Sep 24, 2024
42 checks passed
@surnaik
Copy link
Contributor

surnaik commented Oct 20, 2024

@weiting-chen Why was this bumped up to 1.2.1-SNAPSHOT?

Don't we create a separate branch for 1.2.1 - branch-1.2.1, similar to branch-1.1.1?

@PHILO-HE
Copy link
Contributor

Hi @surnaik, this is following Spark's release convention. Spark uses 3.5.4-SNAPSHOT as development version on branch-3.5, see
https://github.com/apache/spark/blob/branch-3.5/pom.xml#L29. Do you think it makes sense?

@surnaik
Copy link
Contributor

surnaik commented Oct 23, 2024

Hi @surnaik, this is following Spark's release convention. Spark uses 3.5.4-SNAPSHOT as development version on branch-3.5, see https://github.com/apache/spark/blob/branch-3.5/pom.xml#L29. Do you think it makes sense?

Thanks, it makes sense. I was of the opinion that we cut separate branches for each subminor version as well, similar to branch-1.1.1. No worries, this sounds good. In future, we'll stick to the same style as Spark I'm assuming.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants