Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[VL] Fix weekly build job failure #7163

Merged
merged 4 commits into from
Sep 9, 2024
Merged

[VL] Fix weekly build job failure #7163

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
327b700
Initial
PHILO-HE Sep 9, 2024
064bf66
For triggering
PHILO-HE Sep 9, 2024
7df6901
Explicit disable vcpkg
PHILO-HE Sep 9, 2024
b4d0fc1
Revert "For triggering"
PHILO-HE Sep 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions cpp/velox/tests/VeloxShuffleWriterTest.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ TEST_F(VeloxHashShuffleWriterMemoryTest, kStop) {
// Reclaim bytes to shrink partition buffer.
int64_t reclaimed = 0;
ASSERT_NOT_OK(shuffleWriter->reclaimFixedSize(2000, &reclaimed));
ASSERT(reclaimed >= 2000);
ASSERT_TRUE(reclaimed >= 2000);

// Trigger spill during stop.
ASSERT_TRUE(pool.checkEvict(pool.bytes_allocated(), [&] { ASSERT_NOT_OK(shuffleWriter->stop()); }));
Expand All @@ -630,7 +630,7 @@ TEST_F(VeloxHashShuffleWriterMemoryTest, kStopComplex) {
// Reclaim bytes to shrink partition buffer.
int64_t reclaimed = 0;
ASSERT_NOT_OK(shuffleWriter->reclaimFixedSize(2000, &reclaimed));
ASSERT(reclaimed >= 2000);
ASSERT_TRUE(reclaimed >= 2000);

// Reclaim from PartitionWriter to free cached bytes.
auto payloadSize = shuffleWriter->cachedPayloadSize();
Expand Down
2 changes: 1 addition & 1 deletion dev/package.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ cd "$GLUTEN_DIR"

# build gluten with velox backend, prompt always respond y
export PROMPT_ALWAYS_RESPOND=y
./dev/buildbundle-veloxbe.sh --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_hdfs=ON "$@"
./dev/buildbundle-veloxbe.sh --enable_vcpkg=OFF --build_tests=ON --build_benchmarks=ON --enable_s3=ON --enable_hdfs=ON "$@"

# make thirdparty package
./dev/build-thirdparty.sh
Loading