Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-6887][VL] Daily Update Velox Version (2024_08_20) #6928

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

GlutenPerfBot
Copy link
Contributor

Upstream Velox's New Commits:

be529880b by Orri Erling, Wave Metrics (10679)
676b17019 by Hongze Zhang, Add gflag to allow growing buffers that were created in different task (10768)

Copy link

#6887

@zhouyuan
Copy link
Contributor

CC @zhztheplayer shall we fix the memory issue since your fix is landed in Velox?

@zhouyuan
Copy link
Contributor

@GlutenPerfBot benchmark

@GlutenPerfBot
Copy link
Contributor Author

ACK, will benchmark TPCH/DS on this pull request

@zhztheplayer
Copy link
Member

Error

Executing SQL query from resource path /tpcds-queries/q24b.sql...
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fd86d9bd966, pid=6067, tid=0x00007fd874626700
#
# JRE version: OpenJDK Runtime Environment (8.0_312-b07) (build 1.8.0_312-b07)
# Java VM: OpenJDK 64-Bit Server VM (25.312-b07 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libvelox.so+0x1807966]  facebook::velox::memory::ScopedMemoryPoolArbitrationCtx::~ScopedMemoryPoolArbitrationCtx()+0x6
#
# Core dump written. Default location: /__w/incubator-gluten/incubator-gluten/tools/gluten-it/core or core.6067
#
# An error report file with more information is saved as:
# /__w/incubator-gluten/incubator-gluten/tools/gluten-it/hs_err_pid6067.log
#
# If you would like to submit a bug report, please visit:
#   https://bugzilla.redhat.com/enter_bug.cgi?product=Red%20Hat%20Enterprise%20Linux%208&component=java-1.8.0-openjdk
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
sbin/gluten-it.sh: line 50:  6067 Aborted                 (core dumped) $JAVA_HOME/bin/java $SPARK_JVM_OPTIONS $GLUTEN_IT_JVM_ARGS -XX:ErrorFile=/var/log/java/hs_err_pid%p.log -Dio.netty.tryReflectionSetAccessible=true -cp $JAR_PATH org.apache.gluten.integration.Cli $@

@zhztheplayer
Copy link
Member

CC @zhztheplayer shall we fix the memory issue since your fix is landed in Velox?

Yes and I'll raise another PR today for that, we can merge this first.

@GlutenPerfBot
Copy link
Contributor Author

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_6928_time.csv log/native_master_08_19_2024_45d629e1d7_time.csv difference percentage
q1 40.01 39.36 -0.642 98.40%
q2 30.15 30.00 -0.148 99.51%
q3 53.57 53.30 -0.272 99.49%
q4 43.04 42.63 -0.409 99.05%
q5 103.35 104.83 1.480 101.43%
q6 13.32 12.68 -0.644 95.17%
q7 116.76 117.27 0.512 100.44%
q8 114.23 115.19 0.961 100.84%
q9 170.17 169.64 -0.524 99.69%
q10 66.94 64.81 -2.129 96.82%
q11 31.36 26.35 -5.009 84.03%
q12 30.65 32.85 2.197 107.17%
q13 51.82 51.31 -0.510 99.02%
q14 24.93 27.14 2.214 108.88%
q15 52.84 54.69 1.846 103.49%
q16 18.05 17.77 -0.279 98.46%
q17 132.46 130.71 -1.755 98.67%
q18 200.14 197.75 -2.390 98.81%
q19 29.56 30.51 0.950 103.21%
q20 41.61 39.19 -2.418 94.19%
q21 383.92 384.57 0.653 100.17%
q22 18.51 15.48 -3.030 83.63%
total 1767.38 1758.03 -9.343 99.47%

@zhouyuan
Copy link
Contributor

Error

Executing SQL query from resource path /tpcds-queries/q24b.sql...
#
# A fatal error has been detected by the Java Runtime Environment:
#
#  SIGSEGV (0xb) at pc=0x00007fd86d9bd966, pid=6067, tid=0x00007fd874626700
#
# JRE version: OpenJDK Runtime Environment (8.0_312-b07) (build 1.8.0_312-b07)
# Java VM: OpenJDK 64-Bit Server VM (25.312-b07 mixed mode linux-amd64 compressed oops)
# Problematic frame:
# C  [libvelox.so+0x1807966]  facebook::velox::memory::ScopedMemoryPoolArbitrationCtx::~ScopedMemoryPoolArbitrationCtx()+0x6
#
# Core dump written. Default location: /__w/incubator-gluten/incubator-gluten/tools/gluten-it/core or core.6067
#
# An error report file with more information is saved as:
# /__w/incubator-gluten/incubator-gluten/tools/gluten-it/hs_err_pid6067.log
#
# If you would like to submit a bug report, please visit:
#   https://bugzilla.redhat.com/enter_bug.cgi?product=Red%20Hat%20Enterprise%20Linux%208&component=java-1.8.0-openjdk
# The crash happened outside the Java Virtual Machine in native code.
# See problematic frame for where to report the bug.
#
sbin/gluten-it.sh: line 50:  6067 Aborted                 (core dumped) $JAVA_HOME/bin/java $SPARK_JVM_OPTIONS $GLUTEN_IT_JVM_ARGS -XX:ErrorFile=/var/log/java/hs_err_pid%p.log -Dio.netty.tryReflectionSetAccessible=true -cp $JAR_PATH org.apache.gluten.integration.Cli $@

re-trigger it seems passing now, fired one issue to track
#6930

@zhouyuan zhouyuan merged commit c3e9677 into apache:main Aug 20, 2024
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants