-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Sort shuffle writer use vectorized c2r #6782
Conversation
marin-ma
commented
Aug 12, 2024
•
edited by FelixYBW
Loading
edited by FelixYBW
Default | with PR | |
---|---|---|
time of input iterator | 397.95 | 403.29 |
time of scan and filter | 246.58 | 253.03 |
not_counted | 216.78 | 224.2 |
time to shuffle c2r | 159.02 | 134.57 |
time to compress | 93.77 | 93.09 |
time to deserialize | 67.05 | 67.93 |
time to decompress | 49.18 | 49.85 |
shuffle write time | 46.83 | 41.75 |
time of rowConstruction | 43.07 | 44.19 |
time to shuffle sort | 42.95 | 42.99 |
time of project | 42.16 | 41.24 |
time of hash probe | 41.04 | 40.54 |
idle | 34.21 | 23.12 |
time of aggregation | 14.53 | 14.33 |
time of postProjection | 7.83 | 7.83 |
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
67835d7
to
1ae4054
Compare
TPCH SF3T perf, totaltime shuffle c2r 162s -> 138s
|
1ae4054
to
eec1fa4
Compare
This PR is stale because it has been open 45 days with no activity. Remove stale label or comment or this will be closed in 10 days. |
eec1fa4
to
9128319
Compare
9128319
to
7c0382e
Compare
@
@FelixYBW We need to merge this patch to enable the c2r optimization in shuffle. This performance data was measured a few months ago. I will refresh it when jenkins server is back. |