Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Use extractFiltersFromRemainingFilter provided by Velox #6754

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rui-mo
Copy link
Contributor

@rui-mo rui-mo commented Aug 8, 2024

What changes were proposed in this pull request?

#6666

How was this patch tested?

under test

Copy link

github-actions bot commented Aug 8, 2024

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@FelixYBW
Copy link
Contributor

FelixYBW commented Aug 9, 2024

@zhli1142015

@rui-mo how many PRs we need to submit to Velox? since there is a gap between Gluten's

@rui-mo
Copy link
Contributor Author

rui-mo commented Aug 15, 2024

@rui-mo how many PRs we need to submit to Velox? since there is a gap between Gluten's

@FelixYBW I'm still evaluating the gap here. Will update once it's figured out. Thanks.

@rui-mo
Copy link
Contributor Author

rui-mo commented Nov 6, 2024

@GlutenPerfBot benchmark

@FelixYBW
Copy link
Contributor

FelixYBW commented Nov 6, 2024

@FelixYBW I'm still evaluating the gap here. Will update once it's figured out. Thanks.

Any update?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants