[VL] Remove Spark tokenizer #6713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
rui-mo
force-pushed
the
wip_tokenizer
branch
4 times, most recently
from
ac15603
to
7c73911
Compare
FelixYBW
changed the title
rui-mo
force-pushed
the
wip_tokenizer
branch
3 times, most recently
from
56f4fc5
to
ed42260
Compare
rui-mo
changed the title
rui-mo
force-pushed
the
wip_tokenizer
branch
from
ed42260
to
a436665
Compare
PHILO-HE
previously approved these changes
Sep 4, 2024
rui-mo
force-pushed
the
wip_tokenizer
branch
from
a436665
to
efba261
Compare
PHILO-HE
approved these changes
Sep 4, 2024
dcoliversun
pushed a commit
to dcoliversun/gluten
that referenced
this pull request
Sep 11, 2024
zml1206
added a commit
to zml1206/incubator-gluten
that referenced
this pull request
Sep 19, 2024
This reverts commit bdf3421.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
After supporting creating child spec by name in Velox, the field name will not be parsed and thus we can remove the customized Spark tokenizer in Gluten.
How was this patch tested?
Existing unit tests.