-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Skip UTF-8 validation in JSON parsing #6661
[VL] Skip UTF-8 validation in JSON parsing #6661
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
@kecookier, do you care about the UTF-8 encoding validity of JSON string? Do we just need to align with Spark's behavior? cc @wang-zhun |
@PHILO-HE We don't need UTF-8 validity, we just need to be consistent with Spark. |
@PHILO-HE Thanks. Just keep it consistent with Spark. |
Has opened one thread in velox to discuss this issue: facebookincubator/velox#10639. If velox accepts this change, we can close this pr. |
c64d553
to
61d4df4
Compare
@wang-zhun, can you validate this pr with your cases? We can merge this one if CI passes and no issue is on your side. |
@PHILO-HE Thank you, I’ve verified that this patch is effective for my scenario. beforenow |
@kecookier, could you approve this pr if you have no comment? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
Thanks. |
* [VL] Skip UTF-8 validation in JSON parsing (#6661) * [VL] Fix high precision rounding (#6707) --------- Co-authored-by: PHILO-HE <[email protected]> Co-authored-by: Arnav Balyan <[email protected]>
What changes were proposed in this pull request?
See discussion: #5253 (comment)
By default, simdjson lib enables UTF-8 validation to check input json string. However, Spark always disregards the UTF-8 encoding invalidity of input.