Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Update to add centos9 for weekly build #6580

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

deepashreeraghu
Copy link
Contributor

What changes were proposed in this pull request?

To add Centos9 also to weekly builds.

How was this patch tested?

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/apache/incubator-gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@deepashreeraghu
Copy link
Contributor Author

@PHILO-HE - I have added Centos9. But, I had a question : I have used gcc-toolset-12 and apache-maven-3.9.7-bin.tar.gz in my environment while building. Not sure if it will work with other versions too.
Is there anyway that this gets tested ?

@PHILO-HE
Copy link
Contributor

@deepashreeraghu, the modification of velox_weekly.yml can trigger the running of that job. You can check the failure message. If you need to test in local, you can pull a docker image to do the test.

@deepashreeraghu
Copy link
Contributor Author

@PHILO-HE - the build-job went fine with Centos9 too. Please review and let me know.
cc: @majetideepak

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks nice! Thanks!

@PHILO-HE PHILO-HE changed the title Update to add centos9 for weekly build [VL] Update to add centos9 for weekly build Jul 25, 2024
@PHILO-HE PHILO-HE merged commit 751fa83 into apache:main Jul 25, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants