[VL] Move setup-centos7.sh & setup-centos8.sh into Gluten and clean up some script code #6559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/apache/incubator-gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
PHILO-HE
force-pushed
the
clean-script
branch
2 times, most recently
from
384b882
to
64d524a
Compare
PHILO-HE
changed the title
PHILO-HE
force-pushed
the
clean-script
branch
4 times, most recently
from
e85c2ba
to
b8e085b
Compare
|
Can we move facebookincubator/velox@8ceb776 to Gluten as well? so we can remove one PR from oap/velox |
@FelixYBW, yes, this pr is moving that script also. |
rui-mo
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
These two scripts are not kept in upstream velox now.
How was this patch tested?
CI/Weekly build job.