Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Avoid reapplying code patches for external projects when ENABLE_EP_CACHE=ON #3916

Merged
merged 3 commits into from
Dec 5, 2023

Conversation

zhztheplayer
Copy link
Member

This is to fix error "Failed to apply compilation fixes to Velox: ..." when running build scripts with ENABLE_EP_CACHE=ON.

Also, remove option SKIP_BUILD_EP since its functionality overlaps ENABLE_EP_CACHE. One can use ENABLE_EP_CACHE=ON to skip building external projects which were already built earlier.

Copy link

github-actions bot commented Dec 4, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@zhouyuan
Copy link
Contributor

zhouyuan commented Dec 5, 2023

will this also check the compile flags?
e.g. if velox commit does not change, but the compile flags are modified, --enable_hdfs=ON/OFF

@zhztheplayer
Copy link
Member Author

will this also check the compile flags?
e.g. if velox commit does not change, but the compile flags are modified, --enable_hdfs=ON/OFF

No. So the script should be improved then to support that. Currently only commit hash be used as the cache key.

@zhztheplayer
Copy link
Member Author

@zhouyuan @PHILO-HE @rui-mo

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@zhztheplayer zhztheplayer merged commit 144df96 into apache:main Dec 5, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3916_time.csv log/native_master_12_04_2023_94c91c55d_time.csv difference percentage
q1 33.05 34.65 1.599 104.84%
q2 26.32 24.91 -1.413 94.63%
q3 37.92 36.38 -1.533 95.96%
q4 37.76 37.37 -0.390 98.97%
q5 71.63 72.63 0.997 101.39%
q6 6.95 6.87 -0.081 98.83%
q7 84.58 85.44 0.859 101.02%
q8 85.55 87.86 2.317 102.71%
q9 125.35 124.52 -0.833 99.34%
q10 46.75 46.04 -0.710 98.48%
q11 20.14 20.12 -0.011 99.94%
q12 24.95 26.71 1.753 107.02%
q13 45.33 46.45 1.118 102.47%
q14 18.29 14.55 -3.746 79.52%
q15 29.49 28.16 -1.330 95.49%
q16 15.88 15.75 -0.126 99.21%
q17 102.09 103.10 1.012 100.99%
q18 150.09 150.63 0.547 100.36%
q19 13.70 12.90 -0.797 94.18%
q20 27.86 27.73 -0.130 99.53%
q21 222.53 222.80 0.264 100.12%
q22 13.41 13.06 -0.354 97.36%
total 1239.62 1238.63 -0.990 99.92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants