-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Avoid reapplying code patches for external projects when ENABLE_EP_CACHE=ON #3916
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
will this also check the compile flags? |
No. So the script should be improved then to support that. Currently only commit hash be used as the cache key. |
cf51040
to
6c314b5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks!
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
This is to fix error "Failed to apply compilation fixes to Velox: ..." when running build scripts with
ENABLE_EP_CACHE=ON
.Also, remove option SKIP_BUILD_EP since its functionality overlaps ENABLE_EP_CACHE. One can use
ENABLE_EP_CACHE=ON
to skip building external projects which were already built earlier.