Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL]Daily Update Velox Version (20231203) #3913

Merged
merged 1 commit into from
Dec 4, 2023
Merged

[VL]Daily Update Velox Version (20231203) #3913

merged 1 commit into from
Dec 4, 2023

Conversation

yma11
Copy link
Contributor

@yma11 yma11 commented Dec 3, 2023

What changes were proposed in this pull request?

[VL]Daily Update Velox Version (20231203)

How was this patch tested?

CI/CD

Copy link

github-actions bot commented Dec 3, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@yma11 yma11 force-pushed the 12-3 branch 3 times, most recently from 2dd639a to c85fd7f Compare December 4, 2023 07:43
Copy link
Contributor

@JkSelf JkSelf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@JkSelf JkSelf merged commit 94c91c5 into apache:main Dec 4, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3913_time.csv log/native_master_12_03_2023_558039323_time.csv difference percentage
q1 33.17 34.07 0.899 102.71%
q2 26.87 24.77 -2.094 92.21%
q3 37.49 37.57 0.079 100.21%
q4 38.57 37.63 -0.937 97.57%
q5 72.04 71.98 -0.058 99.92%
q6 6.96 7.08 0.122 101.75%
q7 82.58 85.82 3.243 103.93%
q8 87.12 87.36 0.240 100.28%
q9 120.20 123.46 3.253 102.71%
q10 45.12 45.50 0.381 100.84%
q11 20.00 19.71 -0.287 98.56%
q12 26.42 28.46 2.037 107.71%
q13 46.74 46.75 0.006 100.01%
q14 13.67 13.79 0.119 100.87%
q15 28.18 27.74 -0.445 98.42%
q16 15.68 15.40 -0.277 98.23%
q17 102.01 102.03 0.023 100.02%
q18 150.59 150.05 -0.537 99.64%
q19 14.20 12.97 -1.225 91.37%
q20 28.81 27.88 -0.931 96.77%
q21 225.78 225.84 0.063 100.03%
q22 13.08 13.46 0.384 102.94%
total 1235.28 1239.34 4.058 100.33%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_12_04_2023_time.csv log/native_master_12_03_2023_558039323_time.csv difference percentage
q1 34.65 34.07 -0.580 98.33%
q2 24.91 24.77 -0.130 99.48%
q3 36.38 37.57 1.188 103.26%
q4 37.37 37.63 0.264 100.71%
q5 72.63 71.98 -0.645 99.11%
q6 6.87 7.08 0.209 103.04%
q7 85.44 85.82 0.387 100.45%
q8 87.86 87.36 -0.505 99.43%
q9 124.52 123.46 -1.062 99.15%
q10 46.04 45.50 -0.545 98.82%
q11 20.12 19.71 -0.413 97.95%
q12 26.71 28.46 1.754 106.57%
q13 46.45 46.75 0.297 100.64%
q14 14.55 13.79 -0.757 94.79%
q15 28.16 27.74 -0.422 98.50%
q16 15.75 15.40 -0.354 97.75%
q17 103.10 102.03 -1.076 98.96%
q18 150.63 150.05 -0.580 99.62%
q19 12.90 12.97 0.072 100.56%
q20 27.73 27.88 0.154 100.55%
q21 222.80 225.84 3.047 101.37%
q22 13.06 13.46 0.407 103.12%
total 1238.63 1239.34 0.709 100.06%

@Yohahaha
Copy link
Contributor

Yohahaha commented Dec 5, 2023

minor suggestion: append velox commit id or commit msg in pr description, and keep pr description when merging, it helps us to track rebase log. cc @zhouyuan

@zhouyuan
Copy link
Contributor

zhouyuan commented Dec 5, 2023

@Yohahaha thanks for the tip, noted and will apply in future rebase. The idea is to improve the daily rebase and make it as an automatic job eventually

thanks, -yuan

@yma11 yma11 deleted the 12-3 branch December 11, 2023 05:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants