-
Notifications
You must be signed in to change notification settings - Fork 435
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL]Daily Update Velox Version (20231203) #3913
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
2dd639a
to
c85fd7f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
minor suggestion: append velox commit id or commit msg in pr description, and keep pr description when merging, it helps us to track rebase log. cc @zhouyuan |
@Yohahaha thanks for the tip, noted and will apply in future rebase. The idea is to improve the daily rebase and make it as an automatic job eventually thanks, -yuan |
What changes were proposed in this pull request?
[VL]Daily Update Velox Version (20231203)
How was this patch tested?
CI/CD