Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3902][VL] Add documentation to configure the Velox+GCS connector #3902

Merged
merged 2 commits into from
Dec 4, 2023

Conversation

tigrux
Copy link
Contributor

@tigrux tigrux commented Dec 1, 2023

What changes were proposed in this pull request?

This PR adds documentation to configure the Velox+GCS connector.

How was this patch tested?

Only documentation is provided.

Copy link

github-actions bot commented Dec 1, 2023

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@tigrux tigrux changed the title [VL] Add documentation to configure the Velox+GCS connector [GLUTEN-3902][VL] Add documentation to configure the Velox+GCS connector Dec 1, 2023
Copy link

github-actions bot commented Dec 1, 2023

#3902

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for adding the doc

---
layout: page
title: Using GCS with Gluten
nav_order: 3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
nav_order: 3
nav_order: 5

should use 5 here

@tigrux tigrux requested a review from zhouyuan December 4, 2023 04:24
@zhouyuan zhouyuan merged commit 1857959 into apache:main Dec 4, 2023
5 checks passed
@tigrux tigrux deleted the velox-gcs-docs branch December 4, 2023 17:40
@tigrux
Copy link
Contributor Author

tigrux commented Dec 4, 2023

Thanks @zhouyuan !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants