Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Activate CI test for distinct aggregation spill #3762

Merged
merged 4 commits into from
Nov 22, 2023

Conversation

zhztheplayer
Copy link
Member

@zhztheplayer zhztheplayer commented Nov 17, 2023

We had added a low memory CI job for TPC-DS q97 which was failing because at the time spilling support was not added for distinct aggregation. Enable it now to make sure the newly added spilling support could work.

Update: The job is still failing due to some other reasons although distinct spilling is functional. Adding a independent UT instead.

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@apache apache deleted a comment from github-actions bot Nov 20, 2023
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@zhztheplayer zhztheplayer merged commit c799238 into apache:main Nov 22, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3762_time.csv log/native_master_11_21_2023_b40a5f094_time.csv difference percentage
q1 34.14 33.71 -0.426 98.75%
q2 24.63 24.92 0.289 101.17%
q3 37.19 37.63 0.440 101.18%
q4 36.85 35.99 -0.860 97.67%
q5 69.82 70.48 0.654 100.94%
q6 7.30 7.11 -0.195 97.33%
q7 83.95 84.08 0.127 100.15%
q8 87.05 87.02 -0.034 99.96%
q9 122.17 124.24 2.071 101.70%
q10 45.96 46.06 0.104 100.23%
q11 20.14 19.24 -0.893 95.57%
q12 27.51 25.38 -2.129 92.26%
q13 45.77 45.84 0.066 100.14%
q14 16.21 18.33 2.121 113.09%
q15 29.92 28.80 -1.125 96.24%
q16 15.53 15.37 -0.158 98.98%
q17 101.12 100.95 -0.169 99.83%
q18 149.27 146.37 -2.905 98.05%
q19 12.88 12.89 0.005 100.04%
q20 27.77 28.27 0.500 101.80%
q21 220.69 222.09 1.403 100.64%
q22 12.92 12.99 0.072 100.56%
total 1228.79 1227.75 -1.041 99.92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants