-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Activate CI test for distinct aggregation spill #3762
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-on-distinct-spill
branch
from
November 20, 2023 02:55
ab37533
to
95c2645
Compare
Run Gluten Clickhouse CI |
zhztheplayer
force-pushed
the
wip-on-distinct-spill
branch
from
November 21, 2023 09:24
95c2645
to
4da734f
Compare
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
zhouyuan
approved these changes
Nov 22, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had added a low memory CI job for TPC-DS q97 which was failing because at the time spilling support was not added for distinct aggregation. Enable it now to make sure the newly added spilling support could work.
Update: The job is still failing due to some other reasons although distinct spilling is functional. Adding a independent UT instead.