Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] rebase velox to 20231114 #3735

Merged
merged 3 commits into from
Nov 16, 2023
Merged

[VL] rebase velox to 20231114 #3735

merged 3 commits into from
Nov 16, 2023

Conversation

FelixYBW
Copy link
Contributor

rebase velox to 20231114
ByteStream is replaced by ByteInputStream. Velox PR: facebookincubator/velox#7541

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@FelixYBW FelixYBW merged commit fea2222 into apache:main Nov 16, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3735_time.csv log/native_master_11_15_2023_b2c62cde7_time.csv difference percentage
q1 34.12 34.44 0.320 100.94%
q2 22.98 24.85 1.874 108.16%
q3 36.63 38.05 1.424 103.89%
q4 36.99 36.65 -0.342 99.08%
q5 70.48 68.99 -1.483 97.90%
q6 6.83 5.48 -1.347 80.28%
q7 85.30 84.43 -0.874 98.98%
q8 86.69 86.74 0.054 100.06%
q9 118.19 124.14 5.953 105.04%
q10 47.83 45.35 -2.475 94.83%
q11 20.36 19.43 -0.929 95.43%
q12 22.81 26.85 4.042 117.72%
q13 45.86 45.95 0.086 100.19%
q14 15.68 17.38 1.705 110.88%
q15 27.28 27.61 0.331 101.22%
q16 16.07 16.87 0.803 105.00%
q17 100.79 99.28 -1.508 98.50%
q18 147.67 147.53 -0.137 99.91%
q19 13.05 13.00 -0.052 99.60%
q20 27.44 27.64 0.204 100.74%
q21 222.54 222.20 -0.337 99.85%
q22 13.11 12.85 -0.256 98.05%
total 1218.67 1225.73 7.055 100.58%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants