Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3705][FOLLOW][CH] Set the correct agg schema names after mapping one agg function to the other name #3734

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

zzcclp
Copy link
Contributor

@zzcclp zzcclp commented Nov 15, 2023

What changes were proposed in this pull request?

With CH backend, in the final stage, the agg schema names must be the agg_function#exprId#Partial#custom_sum, after mapping the agg function to the other name, it does not modify according to the new one.

(Fixes: #3705)

How was this patch tested?

(Please explain how this patch was tested. E.g. unit tests, integration tests, manual tests)

(If this patch involves UI changes, please attach a screenshot; otherwise, remove this)

…ing one agg function to the other name

With CH backend, in the final stage, the agg schema names must be the `agg_function#exprId#Partial#custom_sum`,
after mapping the agg function to the other name, it does not modify according to the new one.
Copy link

#3705

Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@baibaichen baibaichen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@baibaichen baibaichen merged commit c5ae59d into apache:main Nov 16, 2023
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Support mapping one custom aggregate function to more than one backend functions
2 participants