Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3732][VL] Use arrow result-returning variants FileWriter::Open API #3733

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

yangzhg
Copy link
Member

@yangzhg yangzhg commented Nov 15, 2023

What changes were proposed in this pull request?

Use arrow result-returning variants FileWriter::Open API instead deprecated ones.

(Fixes: #3732)

Copy link

#3732

@yangzhg
Copy link
Member Author

yangzhg commented Nov 30, 2023

@rui-mo @zhztheplayer I would greatly appreciate if you could take a moment to review the changes at your earliest convenience

@rui-mo
Copy link
Contributor

rui-mo commented Nov 30, 2023

@yangzhg Thanks. LGTM. We can merge it after CI passes.

@rui-mo rui-mo merged commit c531abd into apache:main Dec 1, 2023
15 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3733_time.csv log/native_master_11_30_2023_d2980b73a_time.csv difference percentage
q1 33.93 32.81 -1.111 96.72%
q2 24.93 26.03 1.100 104.41%
q3 37.65 37.62 -0.034 99.91%
q4 38.24 37.38 -0.868 97.73%
q5 72.69 72.32 -0.374 99.49%
q6 6.93 6.56 -0.372 94.63%
q7 84.13 86.62 2.487 102.96%
q8 85.37 87.07 1.702 101.99%
q9 124.50 126.83 2.333 101.87%
q10 43.62 47.00 3.379 107.75%
q11 20.13 20.00 -0.134 99.33%
q12 25.76 25.82 0.061 100.24%
q13 45.83 46.37 0.541 101.18%
q14 17.23 16.00 -1.231 92.86%
q15 27.11 27.70 0.595 102.19%
q16 15.47 15.45 -0.018 99.88%
q17 103.18 102.12 -1.059 98.97%
q18 150.15 150.61 0.456 100.30%
q19 13.16 12.85 -0.303 97.70%
q20 27.31 27.48 0.167 100.61%
q21 221.27 226.90 5.622 102.54%
q22 13.61 13.04 -0.574 95.78%
total 1232.22 1244.58 12.365 101.00%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[VL] Gluten use deprecated arrow FileWriter::Open API
3 participants