Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CORE] Fix validation runtime handle leak #3730

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Fix the runtime handle leak on driver side when we do native validation.

How was this patch tested?

Pass CI

@ulysses-you ulysses-you changed the title [CORE] Fix validation runtime hanle leak [CORE] Fix validation runtime handle leak Nov 15, 2023
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@ulysses-you
Copy link
Contributor Author

cc @zhztheplayer @Yohahaha @PHILO-HE thank you

@Yohahaha
Copy link
Contributor

LGTM!

Copy link
Member

@zhztheplayer zhztheplayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zhztheplayer zhztheplayer merged commit 8abe4d3 into apache:main Nov 16, 2023
16 checks passed
@ulysses-you ulysses-you deleted the leak branch November 16, 2023 01:55
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3730_time.csv log/native_master_11_15_2023_b2c62cde7_time.csv difference percentage
q1 32.81 34.44 1.629 104.97%
q2 24.60 24.85 0.250 101.02%
q3 37.25 38.05 0.799 102.14%
q4 35.88 36.65 0.773 102.15%
q5 71.01 68.99 -2.018 97.16%
q6 7.09 5.48 -1.610 77.31%
q7 83.42 84.43 1.009 101.21%
q8 86.73 86.74 0.006 100.01%
q9 121.44 124.14 2.702 102.22%
q10 47.84 45.35 -2.490 94.80%
q11 20.40 19.43 -0.972 95.23%
q12 23.94 26.85 2.910 112.16%
q13 46.43 45.95 -0.482 98.96%
q14 15.36 17.38 2.020 113.15%
q15 27.17 27.61 0.446 101.64%
q16 15.49 16.87 1.383 108.93%
q17 100.76 99.28 -1.488 98.52%
q18 147.83 147.53 -0.293 99.80%
q19 12.94 13.00 0.061 100.47%
q20 27.03 27.64 0.611 102.26%
q21 223.75 222.20 -1.548 99.31%
q22 12.81 12.85 0.040 100.31%
total 1221.99 1225.73 3.741 100.31%

ulysses-you added a commit to ulysses-you/gluten that referenced this pull request Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants