Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL][DNM] rebase velox main branch #3700

Closed
wants to merge 4 commits into from
Closed

Conversation

FelixYBW
Copy link
Contributor

rebase velox main branch

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@FelixYBW
Copy link
Contributor Author

/Benchmark Velox

1 similar comment
@FelixYBW
Copy link
Contributor Author

/Benchmark Velox

@FelixYBW FelixYBW changed the title [VL][DNM] rebase [VL][DNM] rebase velox main branch Nov 14, 2023
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3700_time.csv log/native_master_11_13_2023_7cf715b8a_time.csv difference percentage
q1 33.97 34.59 0.621 101.83%
q2 24.72 24.33 -0.395 98.40%
q3 37.16 37.92 0.761 102.05%
q4 36.98 36.03 -0.953 97.42%
q5 70.13 71.38 1.250 101.78%
q6 5.47 7.19 1.721 131.46%
q7 83.63 84.44 0.811 100.97%
q8 88.03 86.27 -1.753 98.01%
q9 124.03 122.37 -1.667 98.66%
q10 47.14 47.02 -0.117 99.75%
q11 19.57 19.75 0.187 100.95%
q12 25.51 26.95 1.438 105.64%
q13 46.05 46.08 0.031 100.07%
q14 17.26 14.45 -2.807 83.73%
q15 27.45 28.29 0.839 103.06%
q16 15.54 15.79 0.247 101.59%
q17 100.83 100.90 0.066 100.07%
q18 147.80 148.71 0.916 100.62%
q19 15.20 12.92 -2.286 84.96%
q20 26.97 27.47 0.505 101.87%
q21 220.50 220.71 0.207 100.09%
q22 12.71 12.86 0.149 101.17%
total 1226.65 1226.42 -0.228 99.98%

@FelixYBW
Copy link
Contributor Author

/Benchmark Velox

@PHILO-HE
Copy link
Contributor

PHILO-HE commented Nov 15, 2023

Hi @FelixYBW, the build failure may come from velox's recent change for ByteStream, which makes constructor ByteStream() not usable by default. See link.

We may have to pass a pointer of StreamArena when constructing ByteStream.
https://github.com/oap-project/gluten/blob/main/cpp/velox/operators/serializer/VeloxColumnarBatchSerializer.cc#L35
https://github.com/oap-project/gluten/blob/main/cpp/velox/shuffle/VeloxShuffleReader.cc#L165

@FelixYBW
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3700_time.csv log/native_master_11_15_2023_b2c62cde7_time.csv difference percentage
q1 33.69 34.44 0.750 102.23%
q2 24.74 24.85 0.106 100.43%
q3 37.66 38.05 0.393 101.04%
q4 36.68 36.65 -0.032 99.91%
q5 69.70 68.99 -0.702 98.99%
q6 7.09 5.48 -1.606 77.34%
q7 84.75 84.43 -0.322 99.62%
q8 85.15 86.74 1.590 101.87%
q9 119.11 124.14 5.031 104.22%
q10 45.10 45.35 0.258 100.57%
q11 19.68 19.43 -0.248 98.74%
q12 23.55 26.85 3.302 114.02%
q13 45.80 45.95 0.151 100.33%
q14 17.53 17.38 -0.154 99.12%
q15 26.79 27.61 0.824 103.08%
q16 15.17 16.87 1.708 111.26%
q17 99.75 99.28 -0.477 99.52%
q18 146.82 147.53 0.714 100.49%
q19 14.55 13.00 -1.544 89.39%
q20 27.13 27.64 0.508 101.87%
q21 219.53 222.20 2.665 101.21%
q22 12.87 12.85 -0.013 99.90%
total 1212.83 1225.73 12.901 101.06%

@FelixYBW FelixYBW closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants