Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Enable Spark functions for translate, add_months, array_min, array_max #3687

Merged
merged 4 commits into from
Nov 14, 2023

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Nov 13, 2023

How was this patch tested?

including translate, add_months, date_format, array_min, array_max.
These are already enabled in Velox, need to be removed from blacklist

Spark UTs covers the tests.

Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

1 similar comment
Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

Copy link

Run Gluten Clickhouse CI

@zhouyuan zhouyuan changed the title [VL] Enable the support for some Spark functions [VL] Enable Spark functions for translate, add_months, date_format, array_min, array_max Nov 13, 2023
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE changed the title [VL] Enable Spark functions for translate, add_months, date_format, array_min, array_max [VL] Enable Spark functions for translate, add_months, array_min, array_max Nov 14, 2023
@PHILO-HE
Copy link
Contributor Author

Just aware of date_format depends on a velox patch. Moved out it.

@PHILO-HE PHILO-HE merged commit 5dabb5b into apache:main Nov 14, 2023
18 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3687_time.csv log/native_master_11_13_2023_7cf715b8a_time.csv difference percentage
q1 33.05 34.59 1.543 104.67%
q2 24.42 24.33 -0.097 99.60%
q3 37.02 37.92 0.906 102.45%
q4 36.05 36.03 -0.027 99.93%
q5 70.26 71.38 1.113 101.58%
q6 5.37 7.19 1.824 133.97%
q7 83.14 84.44 1.308 101.57%
q8 87.11 86.27 -0.835 99.04%
q9 119.69 122.37 2.676 102.24%
q10 45.08 47.02 1.937 104.30%
q11 19.21 19.75 0.546 102.85%
q12 26.98 26.95 -0.031 99.88%
q13 45.87 46.08 0.203 100.44%
q14 14.84 14.45 -0.387 97.39%
q15 26.95 28.29 1.344 104.99%
q16 15.60 15.79 0.196 101.25%
q17 101.30 100.90 -0.406 99.60%
q18 147.03 148.71 1.680 101.14%
q19 13.00 12.92 -0.087 99.33%
q20 27.76 27.47 -0.283 98.98%
q21 222.63 220.71 -1.925 99.14%
q22 12.84 12.86 0.020 100.15%
total 1215.21 1226.42 11.215 100.92%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants