-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GLUTEN-3625][FOLLOWUP] Always use the hardcode module name #3659
Conversation
Run Gluten Clickhouse CI |
@@ -30,7 +30,6 @@ | |||
|
|||
<modules> | |||
<module>common</module> | |||
<module>${spark.shim.module}</module> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your following up work!
Do we also need to remove the code where spark.shim.module
/spark.test.module
are set?
E.g.:
https://github.com/oap-project/gluten/blob/main/pom.xml#L48
https://github.com/oap-project/gluten/blob/main/pom.xml#L112
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yeah, removed
Run Gluten Clickhouse CI |
Run Gluten Clickhouse CI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
What changes were proposed in this pull request?
Before this pr the follow cmd can not change the project version for sub-module. It seems the maven plugin compatibility is not very good for using property value module name. So this pr reverts the change and go back to use the profile to specify the sub-module to avoid potential issue.
How was this patch tested?
manully test