Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3625][FOLLOWUP] Always use the hardcode module name #3659

Merged
merged 3 commits into from
Nov 10, 2023

Conversation

ulysses-you
Copy link
Contributor

What changes were proposed in this pull request?

Before this pr the follow cmd can not change the project version for sub-module. It seems the maven plugin compatibility is not very good for using property value module name. So this pr reverts the change and go back to use the profile to specify the sub-module to avoid potential issue.

mvn versions:set -DgenerateBackupPoms=false \
  -DnewVersion="1.0.x" \
  -Pspark-3.2,spark-3.3,spark-3.4 -Pbackends-velox -Pspark-ut -Prss

How was this patch tested?

manully test

Copy link

github-actions bot commented Nov 9, 2023

#3625

Copy link

github-actions bot commented Nov 9, 2023

Run Gluten Clickhouse CI

@ulysses-you
Copy link
Contributor Author

cc @PHILO-HE @zzcclp can you take a look again ? thank you

@@ -30,7 +30,6 @@

<modules>
<module>common</module>
<module>${spark.shim.module}</module>
Copy link
Contributor

@PHILO-HE PHILO-HE Nov 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your following up work!
Do we also need to remove the code where spark.shim.module/spark.test.module are set?
E.g.:
https://github.com/oap-project/gluten/blob/main/pom.xml#L48
https://github.com/oap-project/gluten/blob/main/pom.xml#L112

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, removed

Copy link

github-actions bot commented Nov 9, 2023

Run Gluten Clickhouse CI

Copy link

github-actions bot commented Nov 9, 2023

Run Gluten Clickhouse CI

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@PHILO-HE PHILO-HE merged commit 047c993 into apache:main Nov 10, 2023
17 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3659_time.csv log/native_master_11_09_2023_745ecb383_time.csv difference percentage
q1 34.46 33.80 -0.657 98.09%
q2 24.84 24.95 0.112 100.45%
q3 38.37 38.87 0.502 101.31%
q4 37.18 36.96 -0.219 99.41%
q5 69.74 69.94 0.200 100.29%
q6 7.87 7.87 0.003 100.04%
q7 84.28 85.40 1.123 101.33%
q8 87.37 88.61 1.242 101.42%
q9 123.37 121.14 -2.232 98.19%
q10 50.63 54.35 3.723 107.35%
q11 19.57 19.52 -0.052 99.73%
q12 25.69 24.93 -0.762 97.03%
q13 49.00 50.92 1.919 103.92%
q14 18.16 18.17 0.009 100.05%
q15 31.78 30.79 -0.989 96.89%
q16 16.17 16.06 -0.109 99.32%
q17 101.93 101.51 -0.417 99.59%
q18 148.51 148.23 -0.284 99.81%
q19 14.73 14.95 0.217 101.47%
q20 30.56 31.24 0.673 102.20%
q21 225.14 223.30 -1.842 99.18%
q22 13.38 14.24 0.863 106.45%
total 1252.72 1255.74 3.021 100.24%

@ulysses-you ulysses-you deleted the profile branch November 10, 2023 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants