-
Notifications
You must be signed in to change notification settings - Fork 434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[VL] Refine setting shuffle writer local directories #3601
Conversation
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format?
See also: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Currently, shuffle writer local directories are setting through environment variable "GLUTEN_SPARK_LOCAL_DIRS", which is a historical issue and should be refined.
This PR removes setting/getting local directories through environment variable from JNI code path and keep the environment variable "GLUTEN_SPARK_LOCAL_DIRS" only for generic benchmark simulating spilling multiple disks.