[VL] In OAP Velox fork, simplify shrinking/spilling code for Velox memory pool #3586
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for opening a pull request! Could you open an issue for this pull request on Github Issues? https://github.com/oap-project/gluten/issues Then could you also rename commit message and pull request title in the following format? See also: |
zhztheplayer
changed the title
|
/Benchmark Velox |
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
zhztheplayer
changed the title
Yohahaha
reviewed
Nov 2, 2023
| @@ -62,26 +63,28 @@ class ListenableArbitrator : public velox::memory::MemoryArbitrator { | |||
| } | |||
|
|
|||
| void reserveMemory(velox::memory::MemoryPool* pool, uint64_t) override { | |||
| growPool(pool, memoryPoolInitCapacity_); | |||
| std::lock_guard<std::recursive_mutex> l(mutex_); | |||
There was a problem hiding this comment.
👍
could we remove AllocationListener's mutex?
There was a problem hiding this comment.
Let's keep that mutex for now since this one only works in Velox backend.
PHILO-HE
approved these changes
Nov 2, 2023
|
===== Performance report for TPCH SF2000 with Velox backend, for reference only ====
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done some work to minimize the for-pick PR facebookincubator/velox#5790, the change included in this patch would be needed for Gluten then.