Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3548][CH] Bug fix csv file cr at end of line #3549

Merged
merged 2 commits into from
Nov 17, 2023

Conversation

KevinyhZou
Copy link
Contributor

What changes were proposed in this pull request?

(Please fill in changes proposed in this fix)

(Fixes: #3548)

this pr depend on clickhouse pr: ClickHouse/ClickHouse#54340

How was this patch tested?

TEST BY UT

@github-actions
Copy link

#3548

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

1 similar comment
@github-actions
Copy link

Run Gluten Clickhouse CI

@PHILO-HE PHILO-HE changed the title [GLUTEN-3548][CH]Bug fix csv file cr at end of line [GLUTEN-3548][CH] Bug fix csv file cr at end of line Oct 30, 2023
Copy link

Run Gluten Clickhouse CI

Copy link
Contributor

@liuneng1994 liuneng1994 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@liuneng1994 liuneng1994 merged commit 9956fba into apache:main Nov 17, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] TextFile reader can not read csv file while end of line is CR(\r)
2 participants