Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3359] Add Spark3.4 unit test framework #3497

Merged
merged 2 commits into from
Nov 1, 2023

Conversation

JkSelf
Copy link
Contributor

@JkSelf JkSelf commented Oct 23, 2023

What changes were proposed in this pull request?

This PR consists of two commits. The first commit involves copying the spark 33 unit test into spark 34 within gluten-ut. The second commit addresses the compilation issues and disables the failed unit test. And the disabled unit test is recorded here.

How was this patch tested?

Adding spark34 folder in gluten-ut module.

@github-actions
Copy link

#3361

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

2 similar comments
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

4 similar comments
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

2 similar comments
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@JkSelf JkSelf changed the title [GLUTEN-3361] Enable Spark3.4 unit test [GLUTEN-3359] Enable Spark3.4 unit test Oct 30, 2023
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

#3359

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

- name: Build and Run unit test for Spark 3.4.1(slow tests)
run: |
docker exec ubuntu2004-test-spark34-slow-$GITHUB_RUN_ID bash -l -c 'cd /opt/gluten && \
mvn clean install -Pspark-3.4 -Pbackends-velox -Prss -Pspark-ut -DargLine="-Dspark.test.home=/opt/spark331" -DtagsToInclude=org.apache.spark.tags.ExtendedSQLTest'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like we should target for spark341 here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@zhouyuan Yes. Only GlutenParquetIOSuite#SPARK-40128 read DELTA_LENGTH_BYTE_ARRAY encoded strings test throws a Path does not exist exception when reading the input parquet data. However, even when using Spark 3.4.1, it still fails with a velox exception. Therefore, can we use Spark 3.3.1 in this PR and use Spark 3.4.1 in the subsequent PR?

@JkSelf JkSelf changed the title [GLUTEN-3359] Enable Spark3.4 unit test [GLUTEN-3359] Add Spark3.4 unit test framework Nov 1, 2023
Copy link
Contributor

@zhouyuan zhouyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@JkSelf JkSelf merged commit f37e9af into apache:main Nov 1, 2023
19 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3497_time.csv log/native_master_10_31_2023_d0ec9310f_time.csv difference percentage
q1 35.20 34.66 -0.539 98.47%
q2 23.08 24.70 1.615 107.00%
q3 40.18 40.22 0.048 100.12%
q4 36.01 36.02 0.013 100.04%
q5 73.01 71.14 -1.870 97.44%
q6 9.28 7.39 -1.889 79.64%
q7 88.13 88.05 -0.081 99.91%
q8 87.14 86.81 -0.327 99.62%
q9 122.04 122.50 0.457 100.37%
q10 53.51 53.84 0.334 100.62%
q11 19.86 19.59 -0.268 98.65%
q12 26.25 27.64 1.393 105.31%
q13 47.75 50.31 2.560 105.36%
q14 19.00 19.33 0.324 101.71%
q15 33.70 34.74 1.042 103.09%
q16 16.18 16.30 0.117 100.72%
q17 101.93 102.95 1.015 101.00%
q18 148.28 147.95 -0.334 99.77%
q19 16.75 16.80 0.047 100.28%
q20 30.93 34.80 3.878 112.54%
q21 225.88 225.79 -0.086 99.96%
q22 13.18 13.35 0.171 101.30%
total 1267.27 1274.89 7.619 100.60%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants