Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VL] Fix compile issue after rebasing velox #3484

Merged
merged 3 commits into from
Oct 23, 2023

Conversation

PHILO-HE
Copy link
Contributor

@PHILO-HE PHILO-HE commented Oct 23, 2023

Rebased velox to the version of 10/23/2023.
The external/duckdb/tpch/dbgen/libdbgen.a needs to be changed to align with this static lib's change in upstream velox.

@github-actions
Copy link

Thanks for opening a pull request!

Could you open an issue for this pull request on Github Issues?

https://github.com/oap-project/gluten/issues

Then could you also rename commit message and pull request title in the following format?

[GLUTEN-${ISSUES_ID}][COMPONENT]feat/fix: ${detailed message}

See also:

@PHILO-HE PHILO-HE force-pushed the velox-rebase-test branch 2 times, most recently from 21a3f74 to 67879e9 Compare October 23, 2023 06:12
@PHILO-HE
Copy link
Contributor Author

/Benchmark Velox

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3484_time.csv log/native_master_10_19_2023_a9324e620_time.csv difference percentage
q1 35.06 40.32 5.263 115.01%
q2 24.58 24.36 -0.220 99.10%
q3 40.20 40.92 0.718 101.79%
q4 36.29 33.60 -2.684 92.60%
q5 70.39 70.38 -0.018 99.98%
q6 9.40 8.94 -0.460 95.11%
q7 85.06 102.14 17.088 120.09%
q8 87.65 104.41 16.761 119.12%
q9 120.51 156.04 35.523 129.48%
q10 54.45 72.84 18.395 133.78%
q11 19.87 22.07 2.202 111.08%
q12 27.34 34.28 6.940 125.38%
q13 49.41 72.13 22.719 145.98%
q14 18.50 25.22 6.720 136.33%
q15 34.61 40.39 5.772 116.67%
q16 16.16 18.59 2.433 115.05%
q17 101.69 105.84 4.156 104.09%
q18 148.37 217.17 68.807 146.38%
q19 17.03 27.16 10.129 159.47%
q20 30.85 40.56 9.715 131.49%
q21 223.44 335.44 111.999 150.13%
q22 14.21 17.06 2.855 120.09%
total 1265.06 1609.87 344.814 127.26%

@PHILO-HE PHILO-HE changed the title [DNM] Test rebased velox [VL] Fix compile issue after rebasing velox Oct 23, 2023
@PHILO-HE PHILO-HE merged commit 157f42c into apache:main Oct 23, 2023
5 of 13 checks passed
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3484_time.csv log/native_master_10_19_2023_a9324e620_time.csv difference percentage
q1 34.13 40.32 6.186 118.12%
q2 24.80 24.36 -0.445 98.21%
q3 40.06 40.92 0.862 102.15%
q4 37.51 33.60 -3.909 89.58%
q5 71.26 70.38 -0.883 98.76%
q6 8.53 8.94 0.411 104.81%
q7 85.97 102.14 16.179 118.82%
q8 83.74 104.41 20.668 124.68%
q9 120.09 156.04 35.948 129.93%
q10 54.60 72.84 18.243 133.41%
q11 20.29 22.07 1.780 108.77%
q12 26.02 34.28 8.262 131.75%
q13 48.52 72.13 23.616 148.68%
q14 17.50 25.22 7.719 144.11%
q15 33.57 40.39 6.811 120.29%
q16 15.87 18.59 2.719 117.13%
q17 103.58 105.84 2.264 102.19%
q18 147.44 217.17 69.738 147.30%
q19 16.82 27.16 10.339 161.46%
q20 31.49 40.56 9.079 128.83%
q21 220.05 335.44 115.391 152.44%
q22 13.32 17.06 3.742 128.09%
total 1255.15 1609.87 354.717 128.26%

@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_master_10_23_2023_time.csv log/native_master_10_19_2023_a9324e620_time.csv difference percentage
q1 34.61 40.32 5.713 116.51%
q2 24.81 24.36 -0.452 98.18%
q3 39.90 40.92 1.018 102.55%
q4 36.69 33.60 -3.087 91.59%
q5 71.34 70.38 -0.960 98.65%
q6 8.69 8.94 0.252 102.89%
q7 87.86 102.14 14.284 116.26%
q8 84.29 104.41 20.120 123.87%
q9 118.66 156.04 37.376 131.50%
q10 53.69 72.84 19.155 135.68%
q11 20.55 22.07 1.518 107.39%
q12 27.99 34.28 6.291 122.48%
q13 49.56 72.13 22.573 145.55%
q14 18.60 25.22 6.623 135.61%
q15 33.02 40.39 7.362 122.29%
q16 16.27 18.59 2.325 114.29%
q17 102.04 105.84 3.805 103.73%
q18 147.35 217.17 69.828 147.39%
q19 16.60 27.16 10.561 163.62%
q20 30.77 40.56 9.793 131.82%
q21 226.90 335.44 108.534 147.83%
q22 13.32 17.06 3.745 128.12%
total 1263.49 1609.87 346.376 127.41%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants