Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GLUTEN-3450][CH] Support allowPrecisionLoss=false #3463

Merged
merged 9 commits into from
Oct 24, 2023
Merged

Conversation

loneylee
Copy link
Member

What changes were proposed in this pull request?

(Fixes: #3450)

How was this patch tested?

Test by UT

@github-actions
Copy link

#3450

@github-actions
Copy link

Run Gluten Clickhouse CI

2 similar comments
@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@github-actions
Copy link

Run Gluten Clickhouse CI

@loneylee
Copy link
Member Author

@zhouyuan @PHILO-HE @zzcclp Please have a code review.

Copy link
Contributor

@zzcclp zzcclp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@PHILO-HE PHILO-HE left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@zzcclp zzcclp merged commit 7d5e8fb into apache:main Oct 24, 2023
15 checks passed
@loneylee loneylee deleted the 3450 branch October 24, 2023 06:47
@GlutenPerfBot
Copy link
Contributor

===== Performance report for TPCH SF2000 with Velox backend, for reference only ====

query log/native_3463_time.csv log/native_master_10_23_2023_157f42c08_time.csv difference percentage
q1 35.00 34.61 -0.400 98.86%
q2 25.01 24.81 -0.196 99.22%
q3 40.23 39.90 -0.327 99.19%
q4 37.71 36.69 -1.025 97.28%
q5 71.36 71.34 -0.027 99.96%
q6 8.84 8.69 -0.143 98.38%
q7 88.04 87.86 -0.180 99.80%
q8 86.94 84.29 -2.654 96.95%
q9 119.66 118.66 -1.001 99.16%
q10 54.50 53.69 -0.815 98.50%
q11 19.72 20.55 0.832 104.22%
q12 26.24 27.99 1.745 106.65%
q13 48.46 49.56 1.097 102.26%
q14 20.01 18.60 -1.414 92.93%
q15 34.97 33.02 -1.950 94.43%
q16 15.68 16.27 0.585 103.73%
q17 101.74 102.04 0.303 100.30%
q18 148.39 147.35 -1.048 99.29%
q19 16.90 16.60 -0.302 98.21%
q20 30.93 30.77 -0.156 99.49%
q21 223.75 226.90 3.155 101.41%
q22 13.41 13.32 -0.097 99.28%
total 1267.51 1263.49 -4.016 99.68%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CH] Support decimal allowPrecisionLoss=false
4 participants