Optimize rowConstructNeeded

apache · Nov 1, 2023 · b00dfdd · b00dfdd
1 parent c33cf37
commit b00dfdd
Showing 1 changed file with 4 additions and 7 deletions.
diff --git a/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala b/backends-velox/src/main/scala/io/glutenproject/execution/HashAggregateExecTransformer.scala
@@ -437,16 +437,13 @@ case class HashAggregateExecTransformer(
   // Return whether the outputs partial aggregation should be combined for Velox computing.
   // When the partial outputs are multiple-column, row construct is needed.
   private def rowConstructNeeded: Boolean = {
-    for (aggregateExpression <- aggregateExpressions) {
-      aggregateExpression.mode match {
+    aggregateExpressions.exists { aggExpr =>
+      aggExpr.mode match {
         case PartialMerge | Final =>
-          if (aggregateExpression.aggregateFunction.inputAggBufferAttributes.size > 1) {
-            return true
-          }
-        case _ =>
+          aggExpr.aggregateFunction.inputAggBufferAttributes.size > 1
+        case _ => false
       }
     }
-    false
   }
 
   // Return a scalar function node representing row construct function in Velox.