[GLUTEN-1902] Separate the implementations for TranslateTransformer (#…

…1903)
apache · Nov 16, 2023 · 6c9c81b · 6c9c81b
1 parent aab6dbe
commit 6c9c81b
Show file tree

Hide file tree

Showing 5 changed files with 55 additions and 34 deletions.
diff --git a/...lickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala b/...lickhouse/src/main/scala/io/glutenproject/backendsapi/clickhouse/CHSparkPlanExecApi.scala
@@ -378,6 +378,15 @@ class CHSparkPlanExecApi extends SparkPlanExecApi {
     CHEqualNullSafeTransformer(substraitExprName, left, right, original)
   }
 
+  override def genStringTranslateTransformer(
+      substraitExprName: String,
+      srcExpr: ExpressionTransformer,
+      matchingExpr: ExpressionTransformer,
+      replaceExpr: ExpressionTransformer,
+      original: StringTranslate): ExpressionTransformer = {
+    CHStringTranslateTransformer(substraitExprName, srcExpr, matchingExpr, replaceExpr, original)
+  }
+
   override def genStringLocateTransformer(
       substraitExprName: String,
       first: ExpressionTransformer,

diff --git a/backends-clickhouse/src/main/scala/io/glutenproject/expression/CHExpressionTransformer.scala b/backends-clickhouse/src/main/scala/io/glutenproject/expression/CHExpressionTransformer.scala
@@ -335,6 +335,39 @@ case class CHTruncTimestampTransformer(
   }
 }
 
+case class CHStringTranslateTransformer(
+    substraitExprName: String,
+    srcExpr: ExpressionTransformer,
+    matchingExpr: ExpressionTransformer,
+    replaceExpr: ExpressionTransformer,
+    original: StringTranslate)
+  extends ExpressionTransformer {
+
+  override def doTransform(args: java.lang.Object): ExpressionNode = {
+    // In CH, translateUTF8 requires matchingExpr and replaceExpr argument have the same length
+    val matchingNode = matchingExpr.doTransform(args)
+    val replaceNode = replaceExpr.doTransform(args)
+    if (
+      !matchingNode.isInstanceOf[StringLiteralNode] ||
+      !replaceNode.isInstanceOf[StringLiteralNode]
+    ) {
+      throw new UnsupportedOperationException(s"$original not supported yet.")
+    }
+
+    val matchingLiteral = matchingNode.asInstanceOf[StringLiteralNode].getValue
+    val replaceLiteral = replaceNode.asInstanceOf[StringLiteralNode].getValue
+    if (matchingLiteral.length() != replaceLiteral.length()) {
+      throw new UnsupportedOperationException(s"$original not supported yet.")
+    }
+
+    GenericExpressionTransformer(
+      substraitExprName,
+      Seq(srcExpr, matchingExpr, replaceExpr),
+      original)
+      .doTransform(args)
+  }
+}
+
 case class CHStringLocateTransformer(
     substraitExprName: String,
     substrExpr: ExpressionTransformer,

diff --git a/gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala b/gluten-core/src/main/scala/io/glutenproject/backendsapi/SparkPlanExecApi.scala
@@ -254,6 +254,18 @@ trait SparkPlanExecApi {
     GenericExpressionTransformer(substraitExprName, Seq(child), original)
   }
 
+  def genStringTranslateTransformer(
+      substraitExprName: String,
+      srcExpr: ExpressionTransformer,
+      matchingExpr: ExpressionTransformer,
+      replaceExpr: ExpressionTransformer,
+      original: StringTranslate): ExpressionTransformer = {
+    GenericExpressionTransformer(
+      substraitExprName,
+      Seq(srcExpr, matchingExpr, replaceExpr),
+      original)
+  }
+
   def genStringLocateTransformer(
       substraitExprName: String,
       first: ExpressionTransformer,

diff --git a/gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala b/gluten-core/src/main/scala/io/glutenproject/expression/ExpressionConverter.scala
@@ -288,7 +288,7 @@ object ExpressionConverter extends SQLConfHelper with Logging {
           getStructField.ordinal,
           getStructField)
       case t: StringTranslate =>
-        StringTranslateTransformer(
+        BackendsApiManager.getSparkPlanExecApiInstance.genStringTranslateTransformer(
           substraitExprName,
           replaceWithExpressionTransformer(t.srcExpr, attributeSeq),
           replaceWithExpressionTransformer(t.matchingExpr, attributeSeq),

diff --git a/gluten-core/src/main/scala/io/glutenproject/expression/StringExpressionTransformer.scala b/gluten-core/src/main/scala/io/glutenproject/expression/StringExpressionTransformer.scala
@@ -48,39 +48,6 @@ case class String2TrimExpressionTransformer(
   }
 }
 
-case class StringTranslateTransformer(
-    substraitExprName: String,
-    srcExpr: ExpressionTransformer,
-    matchingExpr: ExpressionTransformer,
-    replaceExpr: ExpressionTransformer,
-    original: StringTranslate)
-  extends ExpressionTransformer {
-
-  override def doTransform(args: java.lang.Object): ExpressionNode = {
-    // In CH, translateUTF8 requires matchingExpr and replaceExpr argument have the same length
-    val matchingNode = matchingExpr.doTransform(args)
-    val replaceNode = replaceExpr.doTransform(args)
-    if (
-      !matchingNode.isInstanceOf[StringLiteralNode] ||
-      !replaceNode.isInstanceOf[StringLiteralNode]
-    ) {
-      throw new UnsupportedOperationException(s"$original not supported yet.")
-    }
-
-    val matchingLiteral = matchingNode.asInstanceOf[StringLiteralNode].getValue
-    val replaceLiteral = replaceNode.asInstanceOf[StringLiteralNode].getValue
-    if (matchingLiteral.length() != replaceLiteral.length()) {
-      throw new UnsupportedOperationException(s"$original not supported yet.")
-    }
-
-    GenericExpressionTransformer(
-      substraitExprName,
-      Seq(srcExpr, matchingExpr, replaceExpr),
-      original)
-      .doTransform(args)
-  }
-}
-
 case class RegExpReplaceTransformer(
     substraitExprName: String,
     subject: ExpressionTransformer,