disable columnar table cache in default

apache · Oct 23, 2023 · 043cf83 · 043cf83
1 parent 327b8eb
commit 043cf83
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 18 deletions.
diff --git a/backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/ListenerApiImpl.scala b/backends-velox/src/main/scala/io/glutenproject/backendsapi/velox/ListenerApiImpl.scala
@@ -39,7 +39,7 @@ class ListenerApiImpl extends ListenerApi {
 
   override def onDriverStart(conf: SparkConf): Unit = {
     // sql table cache serializer
-    if (conf.getBoolean(GlutenConfig.COLUMNAR_TABLE_CACHE_ENABLED.key, defaultValue = true)) {
+    if (conf.getBoolean(GlutenConfig.COLUMNAR_TABLE_CACHE_ENABLED.key, defaultValue = false)) {
       conf.set(
         StaticSQLConf.SPARK_CACHE_SERIALIZER.key,
         "org.apache.spark.sql.execution.ColumnarCachedBatchSerializer")

diff --git a/backends-velox/src/test/scala/io/glutenproject/execution/VeloxColumnarCacheSuite.scala b/backends-velox/src/test/scala/io/glutenproject/execution/VeloxColumnarCacheSuite.scala
@@ -109,21 +109,21 @@ class VeloxColumnarCacheSuite extends VeloxWholeStageTransformerSuite with Adapt
     }
   }
 
-  test("Support transform count(1) with table cache") {
-    val cached = spark.table("lineitem").cache()
-    try {
-      val df = spark.sql("SELECT COUNT(*) FROM lineitem")
-      checkAnswer(df, Row(60175))
-      assert(
-        find(df.queryExecution.executedPlan) {
-          case _: RowToVeloxColumnarExec => true
-          case _ => false
-        }.isEmpty
-      )
-    } finally {
-      cached.unpersist()
-    }
-  }
+  // test("Support transform count(1) with table cache") {
+  //   val cached = spark.table("lineitem").cache()
+  //   try {
+  //     val df = spark.sql("SELECT COUNT(*) FROM lineitem")
+  //     checkAnswer(df, Row(60175))
+  //     assert(
+  //       find(df.queryExecution.executedPlan) {
+  //         case _: RowToVeloxColumnarExec => true
+  //         case _ => false
+  //       }.isEmpty
+  //     )
+  //   } finally {
+  //     cached.unpersist()
+  //   }
+  // }
 
   test("no ColumnarToRow for table cache") {
     val cached = spark.table("lineitem").cache()

diff --git a/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala b/gluten-ut/spark33/src/test/scala/io/glutenproject/utils/velox/VeloxTestSettings.scala
@@ -961,7 +961,7 @@ class VeloxTestSettings extends BackendTestSettings {
     // requires resource files from Vanilla spark jar
     .exclude("SPARK-32908: maximum target error in percentile_approx")
   enableSuite[GlutenCachedTableSuite]
-    .exclude("InMemoryRelation statistics")
+    .exclude("GLUTEN - InMemoryRelation statistics")
     // Extra ColumnarToRow is needed to transform vanilla columnar data to gluten columnar data.
     .exclude("SPARK-37369: Avoid redundant ColumnarToRow transition on InMemoryTableScan")
   enableSuite[GlutenFileSourceCharVarcharTestSuite]

diff --git a/shims/common/src/main/scala/io/glutenproject/GlutenConfig.scala b/shims/common/src/main/scala/io/glutenproject/GlutenConfig.scala
@@ -698,7 +698,7 @@ object GlutenConfig {
       .internal()
       .doc("Enable or disable columnar table cache.")
       .booleanConf
-      .createWithDefault(true)
+      .createWithDefault(false)
 
   val COLUMNAR_PHYSICAL_JOIN_OPTIMIZATION_THROTTLE =
     buildConf("spark.gluten.sql.columnar.physicalJoinOptimizationLevel")