Skip to content

Commit

Permalink
avoid to create memory schema operator every time (#635)
Browse files Browse the repository at this point in the history
Co-authored-by: ZENOTME <[email protected]>
  • Loading branch information
ZENOTME and ZENOTME authored Sep 26, 2024
1 parent 4171275 commit 984c91e
Show file tree
Hide file tree
Showing 2 changed files with 24 additions and 7 deletions.
19 changes: 19 additions & 0 deletions crates/iceberg/src/io/file_io.rs
Original file line number Diff line number Diff line change
Expand Up @@ -368,6 +368,7 @@ mod tests {
use std::io::Write;
use std::path::Path;

use bytes::Bytes;
use futures::io::AllowStdIo;
use futures::AsyncReadExt;
use tempfile::TempDir;
Expand Down Expand Up @@ -490,4 +491,22 @@ mod tests {
let io = FileIO::from_path("tmp/||c");
assert!(io.is_err());
}

#[tokio::test]
async fn test_memory_io() {
let io = FileIOBuilder::new("memory").build().unwrap();

let path = format!("{}/1.txt", TempDir::new().unwrap().path().to_str().unwrap());

let output_file = io.new_output(&path).unwrap();
output_file.write("test".into()).await.unwrap();

assert!(io.is_exist(&path.clone()).await.unwrap());
let input_file = io.new_input(&path).unwrap();
let content = input_file.read().await.unwrap();
assert_eq!(content, Bytes::from("test"));

io.delete(&path).await.unwrap();
assert!(!io.is_exist(&path).await.unwrap());
}
}
12 changes: 5 additions & 7 deletions crates/iceberg/src/io/storage.rs
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ use crate::{Error, ErrorKind};
#[derive(Debug)]
pub(crate) enum Storage {
#[cfg(feature = "storage-memory")]
Memory,
Memory(Operator),
#[cfg(feature = "storage-fs")]
LocalFs,
#[cfg(feature = "storage-s3")]
Expand All @@ -56,7 +56,7 @@ impl Storage {

match scheme {
#[cfg(feature = "storage-memory")]
Scheme::Memory => Ok(Self::Memory),
Scheme::Memory => Ok(Self::Memory(super::memory_config_build()?)),
#[cfg(feature = "storage-fs")]
Scheme::Fs => Ok(Self::LocalFs),
#[cfg(feature = "storage-s3")]
Expand Down Expand Up @@ -96,13 +96,11 @@ impl Storage {
let path = path.as_ref();
match self {
#[cfg(feature = "storage-memory")]
Storage::Memory => {
let op = super::memory_config_build()?;

Storage::Memory(op) => {
if let Some(stripped) = path.strip_prefix("memory:/") {
Ok((op, stripped))
Ok((op.clone(), stripped))
} else {
Ok((op, &path[1..]))
Ok((op.clone(), &path[1..]))
}
}
#[cfg(feature = "storage-fs")]
Expand Down

0 comments on commit 984c91e

Please sign in to comment.