Skip to content

Commit

Permalink
Smooth out release steps (#197)
Browse files Browse the repository at this point in the history
Couple of small things:

- The license check failed because the `dist/*` files were there
- Add `dist/*` to gitignore since we don't want to push these files to the repo
- Make `scripts/release.sh` executable
- Align the svn structure with PyIceberg and Java
  • Loading branch information
Fokko authored Feb 16, 2024
1 parent adef9bd commit 03f77b5
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 6 deletions.
3 changes: 2 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,5 @@
/Cargo.lock
.idea
.vscode
**/.DS_Store
**/.DS_Store
dist/*
2 changes: 2 additions & 0 deletions .licenserc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -29,4 +29,6 @@ header:
- 'website/book'
# Generated content by scripts
- '**/DEPENDENCIES.*.tsv'
# Release distributions
- 'dist/*'
comment: on-failure
Empty file modified scripts/release.sh
100644 → 100755
Empty file.
11 changes: 6 additions & 5 deletions website/src/release.md
Original file line number Diff line number Diff line change
Expand Up @@ -169,19 +169,20 @@ First, checkout Iceberg to local directory:

```shell
# As this step will copy all the versions, it will take some time. If the network is broken, please use svn cleanup to delete the lock before re-execute it.
svn co https://dist.apache.org/repos/dist/dev/iceberg/iceberg-rust iceberg-dist-dev
svn co https://dist.apache.org/repos/dist/dev/iceberg/ /tmp/iceberg-dist-dev
```

Then, upload the artifacts:

> The `${release_version}` here should be like `0.2.0-rc.1`
```shell
cd iceberg-dist-dev
# create a directory named by version
mkdir ${release_version}
mkdir /tmp/iceberg-dist-dev/${release_version}
# copy source code and signature package to the versioned directory
cp ${repo_dir}/dist/* ${release_version}/
cp ${repo_dir}/dist/* /tmp/iceberg-dist-dev/iceberg-rust-${release_version}/
# change dir to the svn folder
cd /tmp/iceberg-dist-dev/
# check svn status
svn status
# add to svn
Expand Down Expand Up @@ -222,7 +223,7 @@ The tag to be voted on is ${iceberg_version}.
The release candidate:
https://dist.apache.org/repos/dist/dev/iceberg/iceberg-rust/${release_version}/
https://dist.apache.org/repos/dist/dev/iceberg/iceberg-rust-${release_version}/
Keys to verify the release candidate:
Expand Down

0 comments on commit 03f77b5

Please sign in to comment.