Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#555] improvement(hive): Improve error message about altering an unknown table #556

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

yuqi1129
Copy link
Contributor

What changes were proposed in this pull request?

Change the exception class from RuntimeException to NoSuchTableException when altering an unknown table.

Why are the changes needed?

Improving error messages to be more accurate and readable.

Fix: #555

Does this PR introduce any user-facing change?

NO

How was this patch tested?

Add test int IT.

@github-actions
Copy link

Code Coverage Report

Overall Project 62.35% -0.02% 🟢
Files changed 11.11% 🔴

Module Coverage
core 74.24% -0.07% 🔴
catalog-hive 65.69% 🟢
Files
Module File Coverage
core CatalogOperationDispatcher.java 87.58% -0.7% 🔴
catalog-hive HiveCatalogOperations.java 70.63% 🟢

@jerryshao
Copy link
Contributor

@mchades please help to review this.

Copy link
Contributor

@mchades mchades left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jerryshao jerryshao merged commit fe2ec48 into main Oct 19, 2023
2 checks passed
@yuqi1129 yuqi1129 deleted the issue_555 branch October 19, 2023 11:31
jerryshao pushed a commit that referenced this pull request Oct 26, 2023
…nown table (#556)

### What changes were proposed in this pull request?

Change the exception class from `RuntimeException` to
`NoSuchTableException` when altering an unknown table.

### Why are the changes needed?

Improving error messages to be more accurate and readable.

Fix: #555 

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

Add test int IT.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement] Optimize error message when alter an unknown table
3 participants